Нулевое исключение @Служба в spring @RestController с использованием инъекции конструктора

#java #spring #spring-boot #spring-mvc #nullpointerexception

Вопрос:

Это мой третий личный проект весенней загрузки, я выполняю на 99% ту же конфигурацию, что и раньше, поэтому понятия не имею, почему я получаю эту ошибку на этом.

Проект запускается просто хорошо, но как только я делаю какую-либо петицию на уникальном @RestController, который у меня есть, он сразу же выдает ошибку null. Эта конечная точка получает код страны альфа 2 название города ip-адрес желания, если ip-адрес не указан, он принимает ip-адрес клиента, который используется в качестве параметра для службы@, от которой я получаю значение null. После этого контроллер должен выполнить множество других действий, прежде чем отправлять ожидаемый вывод клиенту, но он никогда не достигает этой точки с момента исключения null в этой @Службе.

Это петиция, которую я примеряю:

 http://localhost:8080/apiv1/get-distance?country=afamp;city=Qalatamp;ip=150.135.184.38  
 There was an unexpected error (type=Internal Server Error, status=500). Cannot invoke "me.givo.distancebetweenus.getdistance.services.CurrentLocationService.getCurrentLocation(String)" because "this.currentLocationService" is null java.lang.NullPointerException: Cannot invoke "me.givo.distancebetweenus.getdistance.services.CurrentLocationService.getCurrentLocation(String)" because "this.currentLocationService" is null  at me.givo.distancebetweenus.getdistance.controllers.DistanceController.getDistance(DistanceController.java:53)  at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)  at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)  at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)  at java.base/java.lang.reflect.Method.invoke(Method.java:568)  at org.springframework.web.method.support.InvocableHandlerMethod.doInvoke(InvocableHandlerMethod.java:205)  at org.springframework.web.method.support.InvocableHandlerMethod.invokeForRequest(InvocableHandlerMethod.java:150)  at org.springframework.web.servlet.mvc.method.annotation.ServletInvocableHandlerMethod.invokeAndHandle(ServletInvocableHandlerMethod.java:117)  at org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.invokeHandlerMethod(RequestMappingHandlerAdapter.java:895)  at org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.handleInternal(RequestMappingHandlerAdapter.java:808)  at org.springframework.web.servlet.mvc.method.AbstractHandlerMethodAdapter.handle(AbstractHandlerMethodAdapter.java:87)  at org.springframework.web.servlet.DispatcherServlet.doDispatch(DispatcherServlet.java:1067)  at org.springframework.web.servlet.DispatcherServlet.doService(DispatcherServlet.java:963)  at org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:1006)  at org.springframework.web.servlet.FrameworkServlet.doGet(FrameworkServlet.java:898)  at javax.servlet.http.HttpServlet.service(HttpServlet.java:655)  at org.springframework.web.servlet.FrameworkServlet.service(FrameworkServlet.java:883)  at javax.servlet.http.HttpServlet.service(HttpServlet.java:764)  at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:227)  at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:162)  at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:53)  at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:189)  at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:162)  at org.springframework.web.filter.RequestContextFilter.doFilterInternal(RequestContextFilter.java:100)  at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:119)  at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:189)  at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:162)  at org.springframework.web.filter.FormContentFilter.doFilterInternal(FormContentFilter.java:93)  at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:119)  at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:189)  at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:162)  at org.springframework.boot.actuate.metrics.web.servlet.WebMvcMetricsFilter.doFilterInternal(WebMvcMetricsFilter.java:96)  at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:119)  at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:189)  at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:162)  at org.springframework.web.filter.CharacterEncodingFilter.doFilterInternal(CharacterEncodingFilter.java:201)  at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:119)  at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:189)  at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:162)  at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:197)  at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:97)  at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:540)  at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:135)  at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:92)  at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:78)  at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:357)  at org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:382)  at org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:65)  at org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:895)  at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1722)  at org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49)  at org.apache.tomcat.util.threads.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1191)  at org.apache.tomcat.util.threads.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:659)  at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)  at java.base/java.lang.Thread.run(Thread.java:833)  

Это мой контроллер:

 package me.givo.distancebetweenus.getdistance.controllers;  import javax.servlet.http.HttpServletRequest; import javax.validation.constraints.Max; import javax.validation.constraints.Min;  import me.givo.distancebetweenus.getdistance.dtos.CityDto; import me.givo.distancebetweenus.getdistance.dtos.CountryDto; import me.givo.distancebetweenus.getdistance.entities.CityEntity; import me.givo.distancebetweenus.getdistance.entities.CountryEntity; import me.givo.distancebetweenus.getdistance.models.ApiCurrentLocationResponse; import me.givo.distancebetweenus.getdistance.models.Coordinate; import me.givo.distancebetweenus.getdistance.models.DistanceResponse; import me.givo.distancebetweenus.getdistance.repositories.ICitiesRepository; import me.givo.distancebetweenus.getdistance.repositories.ICountriesRepository; import me.givo.distancebetweenus.getdistance.services.CurrentLocationService; import org.modelmapper.ModelMapper; import org.springframework.http.HttpStatus; import org.springframework.http.ResponseEntity; import org.springframework.validation.annotation.Validated; import org.springframework.web.bind.annotation.*;  @RequestMapping("/apiv1") @Validated @RestController public class DistanceController {   private final CurrentLocationService currentLocationService;  private final ICitiesRepository citiesRepository;  private final ICountriesRepository countriesRepository;  private final ModelMapper modelMapper;   public DistanceController(CurrentLocationService currentLocationService, ICitiesRepository citiesRepository,  ICountriesRepository countryRepository, ModelMapper modelMapper) {  this.currentLocationService = currentLocationService;  this.citiesRepository = citiesRepository;  this.countriesRepository = countryRepository;  this.modelMapper = modelMapper;  }   @GetMapping("/get-distance")  @ResponseBody  private ResponseEntitylt;Objectgt; getDistance(  @RequestParam(required = true, name = "country") @Min(2) @Max(2) String country,  @RequestParam(required = true, name = "city") String city,  @RequestParam(required = false, name = "ip") @Min(7) @Max(15) String ip,  HttpServletRequest request) {   ApiCurrentLocationResponse currentLocation;  if (ip == null || ip.isEmpty()) {  String requestIP = request.getRemoteAddr();  System.out.println(requestIP);  try {  currentLocation = currentLocationService.getCurrentLocation(requestIP);  } catch (Exception e) {  System.out.println(e.getMessage());  }  } else {  try {  currentLocation = currentLocationService.getCurrentLocation(ip);  } catch (Exception e) {  System.out.println(e.getMessage());  }  }   CountryEntity countryEntity = countriesRepository.getById(country);  CityEntity cityEntity = citiesRepository.getByNameAndCode(city, country);   CountryDto countryDto = convertToCountryDto(countryEntity);  CityDto cityDto = convertToCityDto(cityEntity);   Coordinate currentLocationCoordinate = new Coordinate(currentLocation);  Coordinate destinationCoordinate = new Coordinate(cityDto);   Double distance = currentLocationCoordinate.distanceBetweenUsKm(destinationCoordinate);   DistanceResponse response = new DistanceResponse(countryDto, cityDto, distance);   return ResponseEntity.status(HttpStatus.OK).body(response);  }   private CityDto convertToCityDto(CityEntity cityEntity) {  return modelMapper.map(cityEntity, CityDto.class);  }   private CountryDto convertToCountryDto(CountryEntity countryEntity) {  return modelMapper.map(countryEntity, CountryDto.class);  } }  

This is the «null» @Service:

 package me.givo.distancebetweenus.getdistance.services;  import me.givo.distancebetweenus.getdistance.models.ApiCurrentLocationResponse; import org.springframework.stereotype.Service; import org.springframework.web.reactive.function.client.WebClient;  @Service public class CurrentLocationService {   private final WebClient.Builder webClient;   private final String key = "fakekey347834834892923fake";   public CurrentLocationService(WebClient.Builder webClient) {  this.webClient = webClient;  }   public ApiCurrentLocationResponse getCurrentLocation(String requestIP) {   String url = "https://api.fakeapi.app/json/";  return webClient.baseUrl(url).build().get()  .uri(uriBuilder -gt; uriBuilder  .path(requestIP)  .queryParam("apikey", key)  .build())  .retrieve()  .bodyToMono(ApiCurrentLocationResponse.class)  .block();  } }   

Thanks your really appreciate help. If any other information is required please let me know. Thank you! —————-Edit——————— shivam’s comment gave me the idea of tag with the @Autowired my injections so I did it and I am not getting the null exception in the @Service anymore, it is in the ICountriesRepository instead which is just the next line of code in my @RestController.. These are the changes I did:

 public class DistanceController {   private final CurrentLocationService currentLocationService;  private final ICitiesRepository citiesRepository;  private final ICountriesRepository countriesRepository;  private final ModelMapper modelMapper;   @Autowired  public DistanceController(CurrentLocationService currentLocationService, ICitiesRepository citiesRepository,  ICountriesRepository countriesRepository, ModelMapper modelMapper) {  this.currentLocationService = currentLocationService;  this.citiesRepository = citiesRepository;  this.countriesRepository = countriesRepository;  this.modelMapper = modelMapper;  }  

This is the «new» error log:

 There was an unexpected error (type=Internal Server Error, status=500). Cannot invoke "me.givo.distancebetweenus.getdistance.repositories.ICountriesRepository.getById(Object)" because "this.countriesRepository" is null java.lang.NullPointerException: Cannot invoke "me.givo.distancebetweenus.getdistance.repositories.ICountriesRepository.getById(Object)" because "this.countriesRepository" is null  at me.givo.distancebetweenus.getdistance.controllers.DistanceController.getDistance(DistanceController.java:72)  at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)  at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)  at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)  at java.base/java.lang.reflect.Method.invoke(Method.java:568)  at org.springframework.web.method.support.InvocableHandlerMethod.doInvoke(InvocableHandlerMethod.java:205)  at org.springframework.web.method.support.InvocableHandlerMethod.invokeForRequest(InvocableHandlerMethod.java:150)  at org.springframework.web.servlet.mvc.method.annotation.ServletInvocableHandlerMethod.invokeAndHandle(ServletInvocableHandlerMethod.java:117)  at org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.invokeHandlerMethod(RequestMappingHandlerAdapter.java:895)  at org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.handleInternal(RequestMappingHandlerAdapter.java:808)  at org.springframework.web.servlet.mvc.method.AbstractHandlerMethodAdapter.handle(AbstractHandlerMethodAdapter.java:87)  at org.springframework.web.servlet.DispatcherServlet.doDispatch(DispatcherServlet.java:1067)  at org.springframework.web.servlet.DispatcherServlet.doService(DispatcherServlet.java:963)  at org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:1006)  at org.springframework.web.servlet.FrameworkServlet.doGet(FrameworkServlet.java:898)  at javax.servlet.http.HttpServlet.service(HttpServlet.java:655)  at org.springframework.web.servlet.FrameworkServlet.service(FrameworkServlet.java:883)  at javax.servlet.http.HttpServlet.service(HttpServlet.java:764)  at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:227)  at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:162)  at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:53)  at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:189)  at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:162)  at org.springframework.web.filter.RequestContextFilter.doFilterInternal(RequestContextFilter.java:100)  at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:119)  at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:189)  at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:162)  at org.springframework.web.filter.FormContentFilter.doFilterInternal(FormContentFilter.java:93)  at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:119)  at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:189)  at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:162)  at org.springframework.boot.actuate.metrics.web.servlet.WebMvcMetricsFilter.doFilterInternal(WebMvcMetricsFilter.java:96)  at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:119)  at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:189)  at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:162)  at org.springframework.web.filter.CharacterEncodingFilter.doFilterInternal(CharacterEncodingFilter.java:201)  at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:119)  at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:189)  at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:162)  at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:197)  at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:97)  at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:540)  at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:135)  at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:92)  at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:78)  at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:357)  at org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:382)  at org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:65)  at org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:895)  at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1722)  at org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49)  at org.apache.tomcat.util.threads.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1191)  at org.apache.tomcat.util.threads.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:659)  at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)  at java.base/java.lang.Thread.run(Thread.java:833)  

Существует код icountriesрепозиции:

 package me.givo.distancebetweenus.getdistance.repositories;   import me.givo.distancebetweenus.getdistance.entities.CountryEntity; import org.springframework.data.jpa.repository.JpaRepository; import org.springframework.stereotype.Repository;   @Repository public interface ICountriesRepository extends JpaRepositorylt;CountryEntity, Stringgt; {  }  

Кроме того, я добавляю код @Конфигурации, которую я создал для ModelMapper:

 package me.givo.distancebetweenus.getdistance.config;  import org.modelmapper.ModelMapper; import org.springframework.context.annotation.Bean; import org.springframework.context.annotation.Configuration;  @Configuration public class Config {   @Bean  public ModelMapper modelMapper() {  return new ModelMapper();  }  }   

Комментарии:

1. вы автоматически подключили CurrentLocationService к DistanceController ?

2. Привет, шивам. Я этого не сделал, так как я вводил в конструктор контроллера, но я также попытался добавить автоматическую проводку, и теперь я получаю ту же ошибку null на этот раз в следующем репозитории, который использует контроллер. Я обновлю первоначальный вопрос. Спасибо.

3. Внедрение зависимостей происходит при запуске приложения. Есть ли у вас какие-либо исключения в этот момент?

4. Попробуйте аннотировать конструктор с помощью @Autowired. Spring(начиная с 4.3) автоматически подключает ЕДИНСТВЕННЫЙ конструктор по умолчанию, есть ли конструктор, который вы нам не показывали?

5. Теперь, когда вы создали там беспорядок, пожалуйста, оставьте @Autowire только на конструкторе. Пожалуйста, покажите, как использовать этот класс/интерфейс ICountriesRepository .

Ответ №1:

Я был немного занят в будние дни, поэтому до сих пор не мог просмотреть свой код, и я обнаружил, что единственный метод сопоставления, который есть у моего контроллера, был частным. Я только что обнародовал это, и все уже работает так, как ожидалось. Спасибо всем за потраченное время.