#python #mysql #mysql-python
#python #mysql #mysql-python
Вопрос:
Могу ли я в любом случае уменьшить дублирование моих аргументов? Например, timepattern повторяется 4 раза, и становится трудно отслеживать большие запросы.
sql = ( "SELECT IFNULL(b.inviters/COUNT(DISTINCT c.id),0), "
" FROM_UNIXTIME(c.registered_at, %s) "
"FROM ( SELECT COUNT(1) AS inviters, joindate "
" FROM "
" ( SELECT DISTINCT(y.id) AS inviters, "
" FROM_UNIXTIME(y.registered_at, %s) AS joindate "
" FROM user_invites z "
" INNER JOIN users y ON y.id = z.inviter_id "
" WHERE z.created_at >= %s "
" ) a "
" GROUP BY a.joindate "
" ) b "
"INNER JOIN users c ON FROM_UNIXTIME(c.registered_at, %s) = b.joindate "
"WHERE c.registered_at BETWEEN %s AND %s "
"GROUP BY FROM_UNIXTIME(c.registered_at, %s) " )
args = ( timepattern, timepattern, datestart_int, timepattern,
datestart_int, dateend_int, timepattern )
cursor.execut(sql, args)
data = list(cursor.fetchall())
cursor.close()
connection.close()
Ответ №1:
попробуйте использовать аргументы в качестве словаря параметров и использовать явные аргументы интерполяции строк (ie %(parameter_name)s
) :
sql = ( "SELECT IFNULL(b.inviters/COUNT(DISTINCT c.id),0), "
" FROM_UNIXTIME(c.registered_at, %(timepattern)s) "
"FROM ( SELECT COUNT(1) AS inviters, joindate "
" FROM "
" ( SELECT DISTINCT(y.id) AS inviters, "
" FROM_UNIXTIME(y.registered_at, %(timepattern)s) AS joindate "
" FROM user_invites z "
" INNER JOIN users y ON y.id = z.inviter_id "
" WHERE z.created_at >= %(datestart_int)s "
" ) a "
" GROUP BY a.joindate "
" ) b "
"INNER JOIN users c ON FROM_UNIXTIME(c.registered_at, %(timepattern)s) = b.joindate "
"WHERE c.registered_at BETWEEN %(datestart_int)s AND %(dateend_int)s "
"GROUP BY FROM_UNIXTIME(c.registered_at, %(timepattern)s) " )
args = {
"timepattern" : timepattern,
"datestart_int" : datestart_int,
"dateend_int" : dateend_int,
}
cursor.execute(sql, args)
Ответ №2:
Вы можете указать аргументы как dict, а затем использовать их в запросе, как %(name)s
Например
args = {'timepattern': timepattern, 'dateend_int': dateend_int}
sql = ( "SELECT IFNULL(b.inviters/COUNT(DISTINCT c.id),0), "
" FROM_UNIXTIME(c.registered_at, %(timepattern)s) "
"FROM ( SELECT COUNT(1) AS inviters, joindate "
" FROM "
" ( SELECT DISTINCT(y.id) AS inviters, "
" FROM_UNIXTIME(y.registered_at, %(timepattern)s AS joindate "
" FROM user_invites z "
" INNER JOIN users y ON y.id = z.inviter_id "
" WHERE z.created_at >= %(datestart_int)s "
" ) a "
" GROUP BY a.joindate "
" ) b "
"INNER JOIN users c ON FROM_UNIXTIME(c.registered_at, %(timepattern)s) = b.joindate "
"WHERE c.registered_at BETWEEN %(datestart_int)s AND %(datetart_int)s "
"GROUP BY FROM_UNIXTIME(c.registered_at, %(timepattern)s)" )
cursor.execute(sql, args)
Комментарии:
1. мы определенно согласны, 1 😉